jbsabbagh commented on code in PR #30915:
URL: https://github.com/apache/beam/pull/30915#discussion_r1559218825
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -1342,7 +1357,7 @@ public Read<K, V>
withBadRecordErrorHandler(ErrorHandler<BadRecord, ?> badRecord
/**
* Sets the timeout time for Kafka consumer polling request in the {@link
ReadFromKafkaDoFn}.
- * The default is 2 second.
+ * The default is 2 seconds.
Review Comment:
More description to guide users.
```suggestion
* A lower timeout optimizes for latency.
* Increase the timeout if the consumer is not fetching enough (or any)
records.
* The default is 2 seconds.
```
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -2387,7 +2402,7 @@ public ReadSourceDescriptors<K, V>
withBadRecordErrorHandler(
/**
* Sets the timeout time for Kafka consumer polling request in the {@link
ReadFromKafkaDoFn}.
- * The default is 2 second.
+ * The default is 2 seconds.
Review Comment:
More description to guide users.
```suggestion
* A lower timeout optimizes for latency.
* Increase the timeout if the consumer is not fetching enough (or any)
records.
* The default is 2 seconds.
```
##########
sdks/python/apache_beam/io/kafka.py:
##########
@@ -159,6 +161,8 @@ def __init__(
:param commit_offset_in_finalize: Whether to commit offsets when
finalizing.
:param timestamp_policy: The built-in timestamp policy which is used for
extracting timestamp from KafkaRecord.
+ :param consumer_polling_timeout_seconds: Kafka client polling request
+ timeout time in seconds. Default is 2 seconds.
Review Comment:
A bit more of a description to guide users.
```suggestion
:param consumer_polling_timeout_seconds: Kafka client polling request
timeout time in seconds. A lower timeout optimizes for latency.
Increase
the timeout if the consumer is not fetching enough (or any) records.
Default is 2 seconds.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
