Abacn commented on code in PR #30915:
URL: https://github.com/apache/beam/pull/30915#discussion_r1567725345
##########
sdks/java/io/kafka/upgrade/src/test/java/org/apache/beam/sdk/io/kafka/upgrade/KafkaIOTranslationTest.java:
##########
@@ -75,6 +75,7 @@ public class KafkaIOTranslationTest {
READ_TRANSFORM_SCHEMA_MAPPING.put(
"getValueDeserializerProvider", "value_deserializer_provider");
READ_TRANSFORM_SCHEMA_MAPPING.put("getCheckStopReadingFn",
"check_stop_reading_fn");
+ READ_TRANSFORM_SCHEMA_MAPPING.put("getConsumerPollingTimeout",
"consumer_polling_timeout");
Review Comment:
This fix is not complete. Previously, the error was
```
java.lang.AssertionError: Method getConsumerPollingTimeout will not be
tracked when upgrading the 'KafkaIO.Read' transform. Please update
'KafkaIOTranslation.KafkaIOReadWithMetadataTranslator' to track the new method
and update this test.
```
adding this line, the error became
```
java.lang.AssertionError: Field name consumer_polling_timeout was not found
in the read transform schema defined in KafkaIOReadWithMetadataTranslator.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
