chamikaramj commented on code in PR #30910:
URL: https://github.com/apache/beam/pull/30910#discussion_r1569460364
##########
sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/ManagedSchemaTransformProvider.java:
##########
@@ -51,14 +54,14 @@ public class ManagedSchemaTransformProvider
@Override
public String identifier() {
- return "beam:schematransform:org.apache.beam:managed:v1";
+ return "beam:transform:managed:v1";
Review Comment:
So:
Managed SchemaTransform: beam:transform:managed:v1
Iceberg Read Schematransform: beam:transform:iceberg_read:v1
Iceberg Write Schematransform: beam:transform:iceberg_write:v1
(for both URNs and schema-transform ids)
(document the reason for breaking the convention in the identifier()
methods.)
##########
sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/ManagedSchemaTransformProvider.java:
##########
@@ -51,14 +54,14 @@ public class ManagedSchemaTransformProvider
@Override
public String identifier() {
- return "beam:schematransform:org.apache.beam:managed:v1";
+ return "beam:transform:managed:v1";
Review Comment:
So:
Managed SchemaTransform: `beam:transform:managed:v1`
Iceberg Read Schematransform: `beam:transform:iceberg_read:v1`
Iceberg Write Schematransform: `beam:transform:iceberg_write:v1`
(for both URNs and schema-transform ids)
(document the reason for breaking the convention in the identifier()
methods.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
