ahmedabu98 commented on code in PR #30910:
URL: https://github.com/apache/beam/pull/30910#discussion_r1569586395
##########
sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/ManagedSchemaTransformProvider.java:
##########
@@ -51,14 +54,14 @@ public class ManagedSchemaTransformProvider
@Override
public String identifier() {
- return "beam:schematransform:org.apache.beam:managed:v1";
+ return "beam:transform:managed:v1";
Review Comment:
`beam:transform:managed:v1` for ManagedSchemaTransform makes sense because
it's a unique case.
For IO SchemaTransforms however, I'd think it makes more sense to stick to
the "beam:schematransform:org.apache.beam:<io>:v1" convention. For example
Iceberg read IO will have a urn like `beam:transform:iceberg_read:v1`, whereas
its schematransform implementation will have the identifier
`beam:schematransform:org.apache.beam:iceberg_read:v1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
