ihji commented on a change in pull request #12609:
URL: https://github.com/apache/beam/pull/12609#discussion_r474311248
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StreamingWriteFn.java
##########
@@ -125,6 +148,20 @@ public void finishBundle(FinishBundleContext context)
throws Exception {
for (ValueInSingleWindow<ErrorT> row : failedInserts) {
context.output(failedOutputTag, row.getValue(), row.getTimestamp(),
row.getWindow());
}
+
+ if (histogram.getTotalCount() > options.getLatencyLoggingFrequency()) {
Review comment:
Changed to use seconds instead of the number of requests. I think
setting frequency in time unit is easier and more intuitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
