ihji commented on a change in pull request #12609:
URL: https://github.com/apache/beam/pull/12609#discussion_r474312991
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##########
@@ -131,7 +133,12 @@ public JobService getJobService(BigQueryOptions options) {
@Override
public DatasetService getDatasetService(BigQueryOptions options) {
- return new DatasetServiceImpl(options);
+ return new DatasetServiceImpl(options, null);
+ }
+
+ @Override
+ public DatasetService getDatasetService(BigQueryOptions options, Histogram
histogram) {
Review comment:
We create a new service instance per bundle, so it would be hard to
aggregate the result across multiple bundles if we don't pass a histogram
instance from outside of the service constructor.
We could also instantiate a histogram object inside the service constructor
and merge them later but it's more time consuming (need an iteration over the
bucket array).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
