m-trieu commented on code in PR #30764:
URL: https://github.com/apache/beam/pull/30764#discussion_r1575764755
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ComputationState.java:
##########
@@ -128,21 +152,26 @@ private void forceExecute(Work work) {
executor.forceExecute(work, work.getWorkItem().getSerializedSize());
}
- /** Gets HeartbeatRequests for any work started before refreshDeadline. */
- public ImmutableList<HeartbeatRequest> getKeyHeartbeats(
- Instant refreshDeadline, DataflowExecutionStateSampler sampler) {
- return activeWorkState.getKeyHeartbeats(refreshDeadline, sampler);
+ public ImmutableMap<ShardedKey, Deque<Work>> currentActiveWorkReadOnly() {
+ return activeWorkState.getReadOnlyActiveWork();
}
public void printActiveWork(PrintWriter writer) {
activeWorkState.printActiveWork(writer, Instant.now());
}
- @Override
- public void close() throws Exception {
+ public GetWorkBudget getActiveWorkBudget() {
+ return activeWorkState.currentActiveWorkBudget();
+ }
+
+ public final void close() {
@Nullable ExecutionState executionState;
while ((executionState = executionStateQueue.poll()) != null) {
- executionState.workExecutor().close();
+ try {
+ executionState.workExecutor().close();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
