jackdingilian commented on code in PR #30995:
URL: https://github.com/apache/beam/pull/30995#discussion_r1579832936
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -2075,6 +2078,8 @@ static ReadChangeStream create() {
abstract @Nullable Boolean getCreateOrUpdateMetadataTable();
+ abstract @Nullable Duration getBacklogReplicationAdjustment();
Review Comment:
I'd prefer to leave this as is for consistency with other optional
parameters. We already do a lot of defaulting in ReadChangeStreamIO.expand
instead of pushing down optional params into the DoFns and setting defaults
there.
I don't have a strong preference for either approach but I think we should
keep this consistent with the other parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
