Abacn commented on code in PR #30995:
URL: https://github.com/apache/beam/pull/30995#discussion_r1579967239
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -2312,6 +2337,10 @@ public PCollection<KV<ByteString, ChangeStreamMutation>>
expand(PBegin input) {
if (getCreateOrUpdateMetadataTable() != null) {
shouldCreateOrUpdateMetadataTable = getCreateOrUpdateMetadataTable();
}
+ Duration backlogReplicationAdjustment =
getBacklogReplicationAdjustment();
Review Comment:
nullable is fine. For streaming IO a consideration is upgrade compatibility,
and newly added parameters then need to be nullable and set default in pipeline
submission
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
