Abacn commented on code in PR #31125:
URL: https://github.com/apache/beam/pull/31125#discussion_r1581722468
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java:
##########
@@ -388,8 +398,22 @@ public synchronized BigQueryStorageStreamSource<T>
getCurrentSource() {
// The following line is required to trigger the
`FailedPreconditionException` on which
// the SplitReadStream validation logic depends. Removing it will
cause incorrect
// split operations to succeed.
- newResponseIterator.hasNext();
- storageClient.reportPendingMetrics();
Review Comment:
removed reportPendingMetrics call here otherwise same warning as #31096
seen, because splitAtFraction call thread isn't a work item thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
