Abacn commented on code in PR #31125:
URL: https://github.com/apache/beam/pull/31125#discussion_r1591253151
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java:
##########
@@ -238,9 +245,12 @@ public synchronized boolean advance() throws IOException {
private synchronized boolean readNextRecord() throws IOException {
Iterator<ReadRowsResponse> responseIterator = this.responseIterator;
while (reader.readyForNextReadResponse()) {
+ boolean previous = splitAllowed;
+ splitAllowed = false;
// hasNext call has internal retry. Record throttling metrics after
called
boolean hasNext = responseIterator.hasNext();
storageClient.reportPendingMetrics();
+ splitAllowed = previous;
Review Comment:
Yeah, it is fine to move around these two lines, as long as splitAllowed is
temporarily disabled during hasNext call. Will fix to make it clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
