damccorm commented on code in PR #31217:
URL: https://github.com/apache/beam/pull/31217#discussion_r1595351954
##########
settings.gradle.kts:
##########
@@ -121,6 +121,13 @@ include(":runners:core-java")
include(":runners:direct-java")
include(":runners:extensions-java:metrics")
/* Begin Flink Runner related settings */
+/* When updating these versions, please make sure that the following files are
updated as well:
+ * FLINK_VERSIONS in
.github/actions/setup-default-test-properties/test-properties.json
+ * flink_versions in sdks/go/examples/wasm/README.md
+ * PUBLISHED_FLINK_VERSIONS in
sdks/python/apache_beam/options/pipeline_options.py
+ * PUBLISHED_FLINK_VERSIONS in
sdks/typescript/src/apache_beam/runners/flink.ts
+ * verify versions in
website/www/site/content/en/documentation/runners/flink.md
Review Comment:
Yeah, I didn't know this in advance and only used external stuff when I was
updating it, so anyone should be able to. Its based on compatibility with a
version here -
https://cloud.google.com/dataproc/docs/concepts/versioning/dataproc-release-2.1
- so next would be 1.17.0 for
https://cloud.google.com/dataproc/docs/concepts/versioning/dataproc-release-2.2
I guess
https://github.com/apache/beam/blob/5ff55b1caf109ce1da44500598dfaf4e85ef1caa/sdks/python/apache_beam/runners/interactive/interactive_beam.py#L410
isn't totally clear. Basically, this is just another option for spinning up a
flink cluster if you don't have one ready to go, and it matches what we do in a
bunch of tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
