damccorm commented on code in PR #31217:
URL: https://github.com/apache/beam/pull/31217#discussion_r1595579261
##########
settings.gradle.kts:
##########
@@ -121,6 +121,13 @@ include(":runners:core-java")
include(":runners:direct-java")
include(":runners:extensions-java:metrics")
/* Begin Flink Runner related settings */
+/* When updating these versions, please make sure that the following files are
updated as well:
+ * FLINK_VERSIONS in
.github/actions/setup-default-test-properties/test-properties.json
+ * flink_versions in sdks/go/examples/wasm/README.md
+ * PUBLISHED_FLINK_VERSIONS in
sdks/python/apache_beam/options/pipeline_options.py
+ * PUBLISHED_FLINK_VERSIONS in
sdks/typescript/src/apache_beam/runners/flink.ts
+ * verify versions in
website/www/site/content/en/documentation/runners/flink.md
Review Comment:
I don't think so? I think that typically, Beam's Flink support is behind
Dataproc's; plus, we don't necessarily need to be on the latest Flink supported
by Dataproc.
I think it makes more sense to include this as a Beam task when we deprecate
a Flink version used by the interactive runner. I don't think this is much
toil, is there a reason to try to offload it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
