ahmedabu98 commented on code in PR #31220: URL: https://github.com/apache/beam/pull/31220#discussion_r1595748369
########## .github/workflows/beam_PreCommit_Java_Iceberg_IO_Direct.yml: ########## @@ -13,21 +13,27 @@ # See the License for the specific language governing permissions and # limitations under the License. -name: IcebergIO Unit Tests +name: PreCommit Java IcebergIO Direct Review Comment: Ahh sorry I didn't know this was intentionally done, I can revert back. That's right, I did make this change just to be consistent with the existing naming convention. Some thoughts: - It's been helpful to know that a "PreCommit" test will be run on each commit without having to manually trigger it (without having to delve into the test configuration to see this), so I think having this distinction is useful to keep. I suppose "Unit Tests" can take on the same meaning though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
