Abacn commented on code in PR #31253:
URL: https://github.com/apache/beam/pull/31253#discussion_r1599064852
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWritesShardedRecords.java:
##########
@@ -818,8 +818,8 @@ public void process(
RetryManager<AppendRowsResponse, AppendRowsContext> retryManager =
new RetryManager<>(
Duration.standardSeconds(1),
- Duration.standardSeconds(10),
- 1000,
+ Duration.standardSeconds(20),
+ 500,
Review Comment:
We had discussion of why retry 1000 times by default. There wasn't a good
option and this was kept as is. Now I propose to increase max retry interval to
20s on retryable error (quota error). This could reduce server side pressure a
little bit, while keep the overall behavior similar to before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
