Abacn commented on code in PR #31253:
URL: https://github.com/apache/beam/pull/31253#discussion_r1605657106


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java:
##########
@@ -1081,4 +1084,52 @@ private static Object convertAvroNumeric(Object value) {
   public static ServiceCallMetric writeCallMetric(TableReference 
tableReference) {
     return callMetricForMethod(tableReference, "BigQueryBatchWrite");
   }
+
+  /**
+   * A counter holding a list of counters. Increment the counter will 
increment every sub-counter it
+   * holds.
+   */
+  static class NestedCounter implements Counter, Serializable {
+

Review Comment:
   I also thought about it. Current plan is if there will be a second code path 
using this nested counter, then we should move it to common package (i.e. java 
core). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to