priyansndesai commented on code in PR #31420:
URL: https://github.com/apache/beam/pull/31420#discussion_r1617653254


##########
sdks/go/pkg/beam/core/runtime/exec/datasource.go:
##########
@@ -63,6 +63,11 @@ type DataSource struct {
 
        // Whether the downstream transform only iterates a GBK coder once.
        singleIterate bool
+
+       // state of the SDK with respect to the status of its data channel. If 
it is true, then the SDK
+       // is waiting for data to be sent to it. If it is false, then the SDK 
is not ready to take any

Review Comment:
   done. thanks!



##########
sdks/go/pkg/beam/core/runtime/exec/datasource.go:
##########
@@ -125,9 +130,16 @@ func (n *DataSource) process(ctx context.Context, data 
func(bcr *byteCountReader
        bcr := byteCountReader{reader: &r, count: &byteCount}
 
        for {
+               // The SDK is currently waiting for the Runner to send data for 
it to be
+               // processed. Hence, the boolean is marked as true.

Review Comment:
   done. thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to