priyansndesai commented on code in PR #31420:
URL: https://github.com/apache/beam/pull/31420#discussion_r1619068296
##########
sdks/python/apache_beam/transforms/environments.py:
##########
@@ -111,11 +111,12 @@ class Environment(object):
_known_urns = {} # type: Dict[str, Tuple[Optional[type], ConstructorFn]]
_urn_to_env_cls = {} # type: Dict[str, type]
- def __init__(self,
+ def __init__(
Review Comment:
Removed.
##########
sdks/python/apache_beam/runners/worker/sdk_worker.py:
##########
@@ -745,18 +746,29 @@ def process_bundle_progress(
instruction_id=instruction_id, error=traceback.format_exc())
if processor:
monitoring_infos = processor.monitoring_infos()
+ consuming_received_data = \
+ processor.consuming_received_data
+ return beam_fn_api_pb2.InstructionResponse(
Review Comment:
Done. Thanks!
It wouldn't let me add None. So I added false and edited unit tests
accordingly.
##########
sdks/python/apache_beam/runners/worker/sdk_worker.py:
##########
@@ -745,18 +746,29 @@ def process_bundle_progress(
instruction_id=instruction_id, error=traceback.format_exc())
if processor:
monitoring_infos = processor.monitoring_infos()
+ consuming_received_data = \
Review Comment:
Addressed. Thanks!
##########
sdks/python/apache_beam/runners/worker/bundle_processor.py:
##########
@@ -1112,6 +1131,9 @@ def process_bundle(self, instruction_id):
elif isinstance(element, beam_fn_api_pb2.Elements.Data):
input_op_by_transform_id[element.transform_id].process_encoded(
element.data)
+ # Since we have processed this element, we are now ready to
Review Comment:
Done. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
