m-trieu commented on code in PR #31317:
URL: https://github.com/apache/beam/pull/31317#discussion_r1619294094
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java:
##########
@@ -137,42 +151,52 @@ public StreamingModeExecutionContext(
this.stateNameMap = ImmutableMap.copyOf(stateNameMap);
this.stateCache = stateCache;
this.backlogBytes = UnboundedSource.UnboundedReader.BACKLOG_UNKNOWN;
- this.workIsFailed = () -> Boolean.FALSE;
}
@VisibleForTesting
- public long getBacklogBytes() {
+ public final long getBacklogBytes() {
return backlogBytes;
}
public boolean workIsFailed() {
- return workIsFailed.get();
+ return Optional.ofNullable(work).map(Work::isFailed).orElse(false);
Review Comment:
is it ever possible that this is called when work is not set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
