m-trieu commented on code in PR #31317:
URL: https://github.com/apache/beam/pull/31317#discussion_r1619305985
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/WorkItemScheduler.java:
##########
@@ -20,38 +20,31 @@
import java.util.Collection;
import java.util.function.Consumer;
import javax.annotation.CheckReturnValue;
+import org.apache.beam.runners.dataflow.worker.streaming.Watermarks;
+import org.apache.beam.runners.dataflow.worker.streaming.Work;
import
org.apache.beam.runners.dataflow.worker.windmill.Windmill.LatencyAttribution;
import org.apache.beam.runners.dataflow.worker.windmill.Windmill.WorkItem;
import org.apache.beam.sdk.annotations.Internal;
-import org.checkerframework.checker.nullness.qual.Nullable;
-import org.joda.time.Instant;
@FunctionalInterface
@CheckReturnValue
@Internal
-public interface WorkItemProcessor {
+public interface WorkItemScheduler {
Review Comment:
should we move all of the streaming packages into windmill?
i am not sure about the historical significance of the different package
structures
i would move windmill into streaming put can't move that JNI class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
