ahmedabu98 commented on code in PR #31726:
URL: https://github.com/apache/beam/pull/31726#discussion_r1661349113
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergCatalogConfig.java:
##########
@@ -19,212 +19,39 @@
import com.google.auto.value.AutoValue;
import java.io.Serializable;
+import java.util.Properties;
import javax.annotation.Nullable;
-import
org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableMap;
+import org.apache.beam.sdk.util.ReleaseInfo;
+import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.Maps;
import org.apache.hadoop.conf.Configuration;
-import org.apache.iceberg.CatalogProperties;
import org.apache.iceberg.CatalogUtil;
import org.checkerframework.dataflow.qual.Pure;
@AutoValue
public abstract class IcebergCatalogConfig implements Serializable {
-
- @Pure
- public abstract String getName();
-
- /* Core Properties */
- @Pure
- public abstract @Nullable String getIcebergCatalogType();
-
- @Pure
- public abstract @Nullable String getCatalogImplementation();
-
- @Pure
- public abstract @Nullable String getFileIOImplementation();
-
- @Pure
- public abstract @Nullable String getWarehouseLocation();
-
- @Pure
- public abstract @Nullable String getMetricsReporterImplementation();
-
- /* Caching */
- @Pure
- public abstract boolean getCacheEnabled();
-
- @Pure
- public abstract boolean getCacheCaseSensitive();
-
- @Pure
- public abstract long getCacheExpirationIntervalMillis();
-
- @Pure
- public abstract boolean getIOManifestCacheEnabled();
-
- @Pure
- public abstract long getIOManifestCacheExpirationIntervalMillis();
-
- @Pure
- public abstract long getIOManifestCacheMaxTotalBytes();
-
- @Pure
- public abstract long getIOManifestCacheMaxContentLength();
-
- @Pure
- public abstract @Nullable String getUri();
-
- @Pure
- public abstract int getClientPoolSize();
-
- @Pure
- public abstract long getClientPoolEvictionIntervalMs();
-
- @Pure
- public abstract @Nullable String getClientPoolCacheKeys();
-
- @Pure
- public abstract @Nullable String getLockImplementation();
-
- @Pure
- public abstract long getLockHeartbeatIntervalMillis();
-
- @Pure
- public abstract long getLockHeartbeatTimeoutMillis();
-
- @Pure
- public abstract int getLockHeartbeatThreads();
-
- @Pure
- public abstract long getLockAcquireIntervalMillis();
-
- @Pure
- public abstract long getLockAcquireTimeoutMillis();
-
- @Pure
- public abstract @Nullable String getAppIdentifier();
-
- @Pure
- public abstract @Nullable String getUser();
-
@Pure
- public abstract long getAuthSessionTimeoutMillis();
+ public abstract Properties getProperties();
@Pure
public abstract @Nullable Configuration getConfiguration();
Review Comment:
P.S. I initially wanted to remove this class so users can just pass in a
key-store (ie. `IcebergIO.writeRows(<properties>)`), but later thought it might
be good to keep `IcebergCatalogConfig` so ppl can pass in a custom Hadoop
Configuration.
We may also want to add more features to this class later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
