kennknowles commented on code in PR #31726:
URL: https://github.com/apache/beam/pull/31726#discussion_r1664685593
##########
sdks/java/io/iceberg/build.gradle:
##########
@@ -54,11 +56,12 @@ dependencies {
implementation "org.apache.iceberg:iceberg-parquet:$iceberg_version"
implementation "org.apache.iceberg:iceberg-orc:$iceberg_version"
implementation library.java.hadoop_common
+ // Hadoop GCS filesystem dependencies
+ runtimeOnly library.java.hadoop_client
Review Comment:
I _think_ I'm OK with this... it isn't very Java-like to put optional
dependencies as mandatory dependencies though. Typically these should also be
resolvable via transitive dependencies if we depend on e.g. GCS core which
provides the GCS filesystem.
##########
sdks/java/core/build.gradle:
##########
@@ -98,7 +98,7 @@ dependencies {
permitUnusedDeclared
enforcedPlatform(library.java.google_cloud_platform_libraries_bom)
provided library.java.json_org
implementation library.java.everit_json_schema
- implementation library.java.snake_yaml
+ shadow library.java.snake_yaml
Review Comment:
I'm afraid of this getting changed again. Is it necessarily part of this
change? Is it safe now?
##########
sdks/java/io/iceberg/build.gradle:
##########
@@ -23,6 +23,8 @@ import java.util.stream.Collectors
plugins { id 'org.apache.beam.module' }
applyJavaNature(
automaticModuleName: 'org.apache.beam.sdk.io.iceberg',
+ shadowClosure: {},
+ validateShadowJar: false,
Review Comment:
Why false? I think we want to validate it. Otherwise we end up having
duplicate classes in multiple jars. Basically we want everything in the jar to
be in our namespace, not any other namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
