nehsyc commented on a change in pull request #12678:
URL: https://github.com/apache/beam/pull/12678#discussion_r476909404
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
##########
@@ -100,8 +99,7 @@ public long getBatchSize() {
ParDo.of(new GroupIntoBatchesDoFn<>(batchSize, allowedLateness,
keyCoder, valueCoder)));
}
- @VisibleForTesting
- static class GroupIntoBatchesDoFn<K, InputT>
+ public static class GroupIntoBatchesDoFn<K, InputT>
Review comment:
I assume that we would still need to access to `GroupIntoBatchesDoFn` if
we register a separate translator, to fill USER_FN for example:
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java#L1241.
Can the same transform go though multiple translators? Is that what you were
suggesting?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
