boyuanzz commented on a change in pull request #12678:
URL: https://github.com/apache/beam/pull/12678#discussion_r476991127
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
##########
@@ -100,8 +99,7 @@ public long getBatchSize() {
ParDo.of(new GroupIntoBatchesDoFn<>(batchSize, allowedLateness,
keyCoder, valueCoder)));
}
- @VisibleForTesting
- static class GroupIntoBatchesDoFn<K, InputT>
+ public static class GroupIntoBatchesDoFn<K, InputT>
Review comment:
I was thinking about we could check `GroupIntoBatches` directly but it
turns out that the translation happens after transform expansions, where we
only can get `ParDo(GroupIntoBatchesDoFn)`. One thing we can do to avoid
exposing `GroupIntoBatchesDoFn` is to make `DoFnSignature` understand that this
is a `shardable stateful DoFn`, like what we do for `RESTRICTION_ENCODING`.
@lukecwik Do you have any suggestion here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
