Zawa-ll commented on code in PR #31915:
URL: https://github.com/apache/beam/pull/31915#discussion_r1684802021
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Redistribute.java:
##########
@@ -160,6 +161,7 @@ public PCollection<T> expand(PCollection<T> input) {
return input
.apply("Pair with random key", ParDo.of(new
AssignShardFn<>(numBuckets)))
.apply(Redistribute.<Integer,
T>byKey().withAllowDuplicates(this.allowDuplicates))
+ .apply("Redistribute", ParDo.of(new RedistributeFn<>()))
Review Comment:
Sure, I just move it to the right location, can you please check the code
again?
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Redistribute.java:
##########
@@ -160,6 +161,7 @@ public PCollection<T> expand(PCollection<T> input) {
return input
.apply("Pair with random key", ParDo.of(new
AssignShardFn<>(numBuckets)))
.apply(Redistribute.<Integer,
T>byKey().withAllowDuplicates(this.allowDuplicates))
+ .apply("Redistribute", ParDo.of(new RedistributeFn<>()))
Review Comment:
Sure, I just move it to the right location, can you please check the code
again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
