Zawa-ll commented on code in PR #31915:
URL: https://github.com/apache/beam/pull/31915#discussion_r1694460936
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/RedistributeTest.java:
##########
@@ -289,13 +284,12 @@ public void
testRedistributeAfterFixedWindowsAndGroupByKey() {
@Test
@Category(ValidatesRunner.class)
public void testRedistributeAfterSlidingWindowsAndGroupByKey() {
-
PCollection<KV<String, Iterable<Integer>>> input =
pipeline
.apply(
Create.of(GBK_TESTABLE_KVS)
.withCoder(KvCoder.of(StringUtf8Coder.of(),
VarIntCoder.of())))
- .apply(Window.into(FixedWindows.of(Duration.standardMinutes(10L))))
+
.apply(Window.into(SlidingWindows.of(Duration.standardMinutes(10L))))
Review Comment:
@Abacn Thank you for your response! I notice there are few failing checks
relevant to style checks, I will fix them soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
