chamikaramj commented on code in PR #31785:
URL: https://github.com/apache/beam/pull/31785#discussion_r1692640457


##########
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/schemas/AwsSchemaProvider.java:
##########
@@ -75,9 +75,11 @@ public class AwsSchemaProvider extends 
GetterBasedSchemaProvider {
 
   @SuppressWarnings("rawtypes")
   @Override
-  public List<FieldValueGetter> fieldValueGetters(Class<?> clazz, Schema 
schema) {
+  public List<FieldValueGetter> fieldValueGetters(

Review Comment:
   Noticed that we break backwards compatibility of public fields here but 
probably this is OK since these are expected be util classes intended only 
internal usage ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to