tilgalas commented on code in PR #31785:
URL: https://github.com/apache/beam/pull/31785#discussion_r1693004106
##########
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/schemas/AwsSchemaProvider.java:
##########
@@ -75,9 +75,11 @@ public class AwsSchemaProvider extends
GetterBasedSchemaProvider {
@SuppressWarnings("rawtypes")
@Override
- public List<FieldValueGetter> fieldValueGetters(Class<?> clazz, Schema
schema) {
+ public List<FieldValueGetter> fieldValueGetters(
Review Comment:
good point - this is the consequence of changing the methods' signatures in
the `GetterBasedSchemaProvider` - it's not annotated with `@Internal` so maybe
we should actually remain careful with that interface - maybe I'll add some
default implementations of the backward compatible methods to that class which
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
