m-trieu commented on code in PR #31883:
URL: https://github.com/apache/beam/pull/31883#discussion_r1700574927
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/getdata/FanOutWorkRefreshClient.java:
##########
@@ -44,7 +47,13 @@ public
FanOutWorkRefreshClient(ThrottlingGetDataMetricTracker getDataMetricTrack
this.getDataMetricTracker = getDataMetricTracker;
this.fanOutActiveWorkRefreshExecutor =
Executors.newCachedThreadPool(
- new
ThreadFactoryBuilder().setNameFormat(FAN_OUT_REFRESH_WORK_EXECUTOR_NAME).build());
+ new ThreadFactoryBuilder()
+ // FanOutWorkRefreshClient runs as a background process, don't
let failures crash
+ // the worker.
+ .setUncaughtExceptionHandler(
+ (t, e) -> LOG.error("Unexpected failure in {}",
t.getName(), e))
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
