m-trieu commented on code in PR #31883:
URL: https://github.com/apache/beam/pull/31883#discussion_r1702425170
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcDirectGetWorkStream.java:
##########
@@ -240,25 +234,46 @@ public void sendHealthCheck() {
@Override
protected void onResponse(StreamingGetWorkResponseChunk chunk) {
getWorkThrottleTimer.stop();
- WorkItemBuffer workItemBuffer =
- workItemBuffers.computeIfAbsent(chunk.getStreamId(), unused -> new
WorkItemBuffer());
+ GetWorkItemBuffer workItemBuffer =
+ workItemBuffers.computeIfAbsent(chunk.getStreamId(), unused -> new
GetWorkItemBuffer());
workItemBuffer.append(chunk);
// The entire WorkItem has been received, it is ready to be processed.
if (chunk.getRemainingBytesForWorkItem() == 0) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
