scwhittle commented on code in PR #32134:
URL: https://github.com/apache/beam/pull/32134#discussion_r1714001691
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -1730,8 +1730,6 @@ public PCollection<KafkaRecord<K, V>> expand(PBegin
input) {
.withKeyDeserializerProvider(kafkaRead.getKeyDeserializerProvider())
.withValueDeserializerProvider(kafkaRead.getValueDeserializerProvider())
.withManualWatermarkEstimator()
- .withRedistribute()
Review Comment:
If we believe that Redistribute is a better default, then we could choose to
modify this PR to respect the config to allow disabling redistribute. But
since redistribute appears to only work if duplicates are allowed that seems
like a dangerous default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
