scwhittle commented on code in PR #32134:
URL: https://github.com/apache/beam/pull/32134#discussion_r1718292053
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -1730,8 +1730,6 @@ public PCollection<KafkaRecord<K, V>> expand(PBegin
input) {
.withKeyDeserializerProvider(kafkaRead.getKeyDeserializerProvider())
.withValueDeserializerProvider(kafkaRead.getValueDeserializerProvider())
.withManualWatermarkEstimator()
- .withRedistribute()
Review Comment:
There is such an option and it is used correctly a few lines below. The bug
is that we are using redistribute/allowduplicates regardless of that
configuration here.
```
if (kafkaRead.isRedistributed()) {
readTransform = readTransform.withRedistribute();
}
if (kafkaRead.isAllowDuplicates()) {
readTransform = readTransform.withAllowDuplicates();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
