damondouglas commented on code in PR #32264:
URL: https://github.com/apache/beam/pull/32264#discussion_r1725354634
##########
runners/prism/java/src/main/java/org/apache/beam/runners/prism/PrismRunner.java:
##########
@@ -72,15 +72,50 @@ public PipelineResult run(Pipeline pipeline) {
prismPipelineOptions.getDefaultEnvironmentType(),
prismPipelineOptions.getJobEndpoint());
- return internal.run(pipeline);
+ Runnable closer = runPrismAndProvideCloser(prismPipelineOptions);
+ try {
+ JobServicePipelineResult delegateResult = (JobServicePipelineResult)
internal.run(pipeline);
+ PrismPipelineResult result = new PrismPipelineResult(delegateResult,
closer);
+ CompletableFuture<?> ignored =
+
delegateResult.getTerminalStateFuture().whenComplete(result::onJobStateComplete);
+ if (isInvokedInTest()) {
+ LOG.info("invoking Pipeline::waitUntilFinish due to invoking in a
class named ^.*Test$");
+ result.waitUntilFinish();
+ }
+ return result;
+ } catch (RuntimeException e) {
+ closer.run();
+ throw e;
+ }
+ }
+
+ private boolean isInvokedInTest() {
+ for (StackTraceElement element : Thread.currentThread().getStackTrace()) {
+ if (element.getClassName().endsWith("Test")) {
+ return true;
+ }
+ }
+ return false;
}
- private static void assignDefaultsIfNeeded(PrismPipelineOptions
prismPipelineOptions) {
- if
(Strings.isNullOrEmpty(prismPipelineOptions.getDefaultEnvironmentType())) {
-
prismPipelineOptions.setDefaultEnvironmentType(Environments.ENVIRONMENT_LOOPBACK);
+ private static void assignDefaultsIfNeeded(PrismPipelineOptions options) {
+ if (Strings.isNullOrEmpty(options.getDefaultEnvironmentType())) {
+ options.setDefaultEnvironmentType(Environments.ENVIRONMENT_LOOPBACK);
}
- if (Strings.isNullOrEmpty(prismPipelineOptions.getJobEndpoint())) {
- prismPipelineOptions.setJobEndpoint(DEFAULT_PRISM_ENDPOINT);
+ if (Strings.isNullOrEmpty(options.getJobEndpoint())) {
+ options.setJobEndpoint(DEFAULT_PRISM_ENDPOINT);
Review Comment:
That's an easy fix. I can have it select randomly based on the freely
available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
