damondouglas commented on code in PR #32264:
URL: https://github.com/apache/beam/pull/32264#discussion_r1725356225
##########
runners/prism/java/src/test/java/org/apache/beam/runners/prism/PrismRunnerTest.java:
##########
@@ -17,48 +17,115 @@
*/
package org.apache.beam.runners.prism;
-import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assume.assumeTrue;
-import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.StreamSupport;
import org.apache.beam.sdk.Pipeline;
-import org.apache.beam.sdk.PipelineResult;
import org.apache.beam.sdk.options.PipelineOptionsFactory;
+import org.apache.beam.sdk.state.TimeDomain;
+import org.apache.beam.sdk.state.Timer;
+import org.apache.beam.sdk.state.TimerSpec;
+import org.apache.beam.sdk.state.TimerSpecs;
+import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.transforms.Create;
-import org.apache.beam.sdk.transforms.PeriodicImpulse;
+import org.apache.beam.sdk.transforms.DoFn;
+import org.apache.beam.sdk.transforms.GroupByKey;
+import org.apache.beam.sdk.transforms.ParDo;
+import org.apache.beam.sdk.transforms.WithKeys;
+import org.apache.beam.sdk.transforms.WithTimestamps;
+import org.apache.beam.sdk.transforms.windowing.FixedWindows;
+import org.apache.beam.sdk.transforms.windowing.Window;
+import org.apache.beam.sdk.values.KV;
+import org.apache.beam.sdk.values.PCollection;
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Strings;
+import org.joda.time.Duration;
+import org.joda.time.Instant;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/** Tests for {@link PrismRunner}. */
-
-// TODO(https://github.com/apache/beam/issues/31793): Remove @Ignore after
finalizing PrismRunner.
-// Depends on: https://github.com/apache/beam/issues/31402 and
-// https://github.com/apache/beam/issues/31792.
-@Ignore
@RunWith(JUnit4.class)
public class PrismRunnerTest {
+
// See build.gradle for test task configuration.
private static final String PRISM_BUILD_TARGET_PROPERTY_NAME =
"prism.buildTarget";
@Test
- public void givenBoundedSource_runsUntilDone() {
+ public void create() {
Pipeline pipeline = Pipeline.create(options());
- pipeline.apply(Create.of(1, 2, 3));
- PipelineResult.State state = pipeline.run().waitUntilFinish();
- assertThat(state).isEqualTo(PipelineResult.State.DONE);
+ PAssert.that(pipeline.apply(Create.of(1, 2, 3))).containsInAnyOrder(1, 2,
3);
+ pipeline.run();
}
+ @Ignore
Review Comment:
Late night pull request is the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
