sjvanrossum commented on code in PR #32060:
URL: https://github.com/apache/beam/pull/32060#discussion_r1751654818
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/MessageReceiver.java:
##########
@@ -19,14 +19,15 @@
import com.solacesystems.jcsmp.BytesXMLMessage;
import java.io.IOException;
+import java.io.Serializable;
/**
* Interface for receiving messages from a Solace broker.
*
* <p>Implementations of this interface are responsible for managing the
connection to the broker
* and for receiving messages from the broker.
*/
-public interface MessageReceiver {
+public interface MessageReceiver extends Serializable {
Review Comment:
Does this really need to be Serializable?
It looks like this is only created at runtime and could be marked transient
wherever it's stored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
