sjvanrossum commented on code in PR #32060:
URL: https://github.com/apache/beam/pull/32060#discussion_r1751703436
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SessionService.java:
##########
@@ -195,42 +221,49 @@ private static JCSMPProperties
overrideConnectorProperties(
LOG.warn(
"SolaceIO.Write: Overriding MESSAGE_CALLBACK_ON_REACTOR to false
since"
+ " HIGHER_THROUGHPUT mode was selected");
+ props.setProperty(JCSMPProperties.MESSAGE_CALLBACK_ON_REACTOR, false);
}
- props.setProperty(JCSMPProperties.MESSAGE_CALLBACK_ON_REACTOR, false);
-
Integer ackWindowSize =
props.getIntegerProperty(JCSMPProperties.PUB_ACK_WINDOW_SIZE);
if ((ackWindowSize != null && ackWindowSize != BATCHED_PUB_ACK_WINDOW)) {
LOG.warn(
String.format(
"SolaceIO.Write: Overriding PUB_ACK_WINDOW_SIZE to %d since"
+ " HIGHER_THROUGHPUT mode was selected",
BATCHED_PUB_ACK_WINDOW));
+ props.setProperty(JCSMPProperties.PUB_ACK_WINDOW_SIZE,
BATCHED_PUB_ACK_WINDOW);
}
- props.setProperty(JCSMPProperties.PUB_ACK_WINDOW_SIZE,
BATCHED_PUB_ACK_WINDOW);
- } else {
+
+ } else if (mode == SolaceIO.SubmissionMode.LOWER_LATENCY) {
// Send from the same thread where the produced is being called. This
offers the lowest
Review Comment:
Do you really want to remodel the properties of Solace's API in this
connector using different names? Can't this connector expose a
`.withProperties(java.util.Properties)` and convert that using
`JCSMPProperties.fromProperties(java.util.Properties)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
