ahmedabu98 commented on code in PR #32451:
URL: https://github.com/apache/beam/pull/32451#discussion_r1761661111
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergIO.java:
##########
@@ -77,6 +90,21 @@ public WriteRows to(DynamicDestinations destinations) {
return toBuilder().setDynamicDestinations(destinations).build();
}
+ /**
+ * Sets the frequency at which data is committed and a new {@link
org.apache.iceberg.Snapshot}
+ * is produced.
+ *
+ * <p>Every triggeringFrequency duration, all accumulated {@link
Review Comment:
good call, I softened it up
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergWriteSchemaTransformProvider.java:
##########
@@ -17,13 +17,21 @@
*/
package org.apache.beam.sdk.io.iceberg;
+import static
org.apache.beam.sdk.io.iceberg.IcebergWriteSchemaTransformProvider.Configuration;
+
import com.google.auto.service.AutoService;
+import com.google.auto.value.AutoValue;
import java.util.Collections;
import java.util.List;
+import java.util.Map;
+import javax.annotation.Nullable;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
