ahmedabu98 commented on code in PR #32451:
URL: https://github.com/apache/beam/pull/32451#discussion_r1761661502
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergWriteSchemaTransformProvider.java:
##########
@@ -57,8 +66,59 @@ public String description() {
+ "{\"table\" (str), \"operation\" (str), \"summary\" (map[str, str]),
\"manifestListLocation\" (str)}";
}
+ @DefaultSchema(AutoValueSchema.class)
+ @AutoValue
+ public abstract static class Configuration {
+ public static Builder builder() {
+ return new
AutoValue_IcebergWriteSchemaTransformProvider_Configuration.Builder();
+ }
+
+ @SchemaFieldDescription("Identifier of the Iceberg table.")
+ public abstract String getTable();
+
+ @SchemaFieldDescription("Name of the catalog containing the table.")
+ @Nullable
Review Comment:
Thanks for this. AutoValue wasn't recognizing checkerframework's `Nullable`
annotation as it is placed here, so I switched to javax. Looks like I just had
the annotation in the wrong place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
