tvalentyn commented on code in PR #32478:
URL: https://github.com/apache/beam/pull/32478#discussion_r1762118679


##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -362,6 +362,9 @@ def get_all_options(
             'used for internal purposes.' % (','.join(unknown_args)))
       i = 0
       while i < len(unknown_args):
+        # End of argument parsing.
+        if unknown_args[i] == '--':

Review Comment:
   Is this related to original intent of this PR or  a new behavior to enable 
passing args that shouldn't be parsed? 
   
   Can this cause breaking changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to