robertwb commented on code in PR #32478:
URL: https://github.com/apache/beam/pull/32478#discussion_r1764060833
##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -362,6 +362,9 @@ def get_all_options(
'used for internal purposes.' % (','.join(unknown_args)))
i = 0
while i < len(unknown_args):
+ # End of argument parsing.
+ if unknown_args[i] == '--':
Review Comment:
Argparse (as do most other argument parsers) stop parsing anything after a
bare `--` as flag values. I added this because I saw a case internally that
passed some command line arguments, including a bare `--`, to the options that
ended up getting parsed even though they weren't before.
This shouldn't be a breaking change, if anything it'll make things more
consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
