RustedBones commented on code in PR #32514:
URL: https://github.com/apache/beam/pull/32514#discussion_r1768623198
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -1441,24 +1445,6 @@ void cleanup(PassThroughThenCleanup.ContextContainer c)
throws Exception {
return rows;
}
- private static Schema getFinalSchema(
- Schema beamSchema, ValueProvider<List<String>> selectedFields) {
- List<Schema.Field> flds =
- beamSchema.getFields().stream()
- .filter(
- field -> {
- if (selectedFields != null
- && selectedFields.isAccessible()
- && selectedFields.get() != null) {
- return selectedFields.get().contains(field.getName());
Review Comment:
selected nested field were always filtered out the beam schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]