arunpandianp commented on code in PR #32566:
URL: https://github.com/apache/beam/pull/32566#discussion_r1776096137
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ComputationWorkExecutor.java:
##########
@@ -83,11 +83,11 @@ public final void executeWork(
* cannot be reused.
*/
public final void invalidate() {
- context().invalidateCache();
try {
+ context().invalidateCache();
Review Comment:
lets keep it outside and not suppress the exception. I'm not sure about the
implications of suppressing the exception here, it is better to fail than
operating in an inconsistent state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
