arunpandianp commented on code in PR #32566:
URL: https://github.com/apache/beam/pull/32566#discussion_r1776147451
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ComputationWorkExecutor.java:
##########
@@ -83,11 +83,11 @@ public final void executeWork(
* cannot be reused.
*/
public final void invalidate() {
- context().invalidateCache();
try {
+ context().invalidateCache();
Review Comment:
I think either is okay here, since even if we throw it the upper layer
suppresses it. But in general it is better to not suppress unexpected
exceptions and let the upper layer handle or re-throw it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
