prodriguezdefino commented on code in PR #32529:
URL: https://github.com/apache/beam/pull/32529#discussion_r1777921531


##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -2523,6 +2532,7 @@ def __init__(
       use_at_least_once=False,
       with_auto_sharding=False,
       num_storage_api_streams=0,
+      cdc_writes_with_primary_key: List[str] = None,

Review Comment:
   added the callable argument to the constructor. 
   
   I enforced the types for the callable to make sure we already have a Row 
that will be used to extract the CDC info of it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to