prodriguezdefino commented on code in PR #32529:
URL: https://github.com/apache/beam/pull/32529#discussion_r1777919686
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java:
##########
@@ -468,15 +507,33 @@ BigQueryIO.Write<Row>
createStorageWriteApiTransform(Schema schema) {
if (configuration.getTable().equals(DYNAMIC_DESTINATIONS)) {
checkArgument(
- schema.getFieldNames().equals(Arrays.asList("destination",
"record")),
+ schema.getFieldNames().containsAll(Arrays.asList("destination",
"record")),
"When writing to dynamic destinations, we expect Row Schema with a
"
+ "\"destination\" string field and a \"record\" Row field.");
+ RowDynamicDestinations dynamicDestination =
+ new
RowDynamicDestinations(schema.getField("record").getType().getRowSchema());
+
+ if (isCdcConfigured()) {
Review Comment:
moved the configuration logic to a separated if branch.
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java:
##########
@@ -207,7 +211,8 @@ public void validate() {
*/
public static Builder builder() {
return new
AutoValue_BigQueryStorageWriteApiSchemaTransformProvider_BigQueryStorageWriteApiSchemaTransformConfiguration
- .Builder();
+ .Builder()
+ .setUseCdcWritesWithPrimaryKey(ImmutableList.of());
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
