ahmedabu98 commented on code in PR #32705:
URL: https://github.com/apache/beam/pull/32705#discussion_r1793088933
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/CoderRegistry.java:
##########
@@ -195,11 +197,12 @@ public <T> Coder<T> coderFor(
* the lexicographically smallest {@link Class#getName() class name}
being used.
* </ul>
*/
- public static CoderRegistry createDefault() {
- return new CoderRegistry();
+ public static CoderRegistry createDefault(@Nullable SchemaRegistry
schemaRegistry) {
+ return new CoderRegistry(schemaRegistry);
}
Review Comment:
This might be a breaking change for users
Can we have the old createDefault() method as well and have it return new
CoderRegistry(null)?
Would maintain existing use cases and limit the number of files in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
