reuvenlax commented on code in PR #32705:
URL: https://github.com/apache/beam/pull/32705#discussion_r1793841121
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/CoderRegistry.java:
##########
@@ -195,11 +197,12 @@ public <T> Coder<T> coderFor(
* the lexicographically smallest {@link Class#getName() class name}
being used.
* </ul>
*/
- public static CoderRegistry createDefault() {
- return new CoderRegistry();
+ public static CoderRegistry createDefault(@Nullable SchemaRegistry
schemaRegistry) {
+ return new CoderRegistry(schemaRegistry);
}
Review Comment:
Good point as this is a public method (even though it's probably not
intended for use outside of core Beam). Added the old createDefault() back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
