ahmedabu98 commented on code in PR #32688:
URL: https://github.com/apache/beam/pull/32688#discussion_r1795463295
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergUtils.java:
##########
@@ -322,6 +354,55 @@ private static void copyFieldIntoRecord(Record rec,
Types.NestedField field, Row
}
}
+ /**
+ * Returns the appropriate value for an Iceberg timestamp field
+ *
+ * <p>If `timestamp`, we resolve incoming values to a {@link LocalDateTime}.
+ *
+ * <p>If `timestamptz`, we resolve to a UTC {@link OffsetDateTime}. Iceberg
already resolves all
+ * incoming timestamps to UTC, so there is no harm in doing it from our side.
+ *
+ * <p>Valid types are:
+ *
+ * <ul>
+ * <li>{@link SqlTypes.DATETIME} --> {@link LocalDateTime}
+ * <li>{@link Schema.FieldType.DATETIME} --> {@link Instant}
+ * <li>{@link Schema.FieldType.INT64} --> {@link Long}
+ * <li>{@link Schema.FieldType.STRING} --> {@link String}
+ * </ul>
+ */
+ private static Object getIcebergTimestampValue(Object beamValue, boolean
shouldAdjustToUtc) {
Review Comment:
Thanks, I tried this but it seems to always pick
`convertBeamTimestampToUTC(Object beamValue)`. Java's method overloading is
static polymorphism, meaning the method is determined at compile time, not
runtime. Unfortunately we don't know the type of `beamValue` at compile time so
it's always treated as an `Object`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
