ahmedabu98 commented on code in PR #32688:
URL: https://github.com/apache/beam/pull/32688#discussion_r1795468186
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergUtils.java:
##########
@@ -345,16 +426,31 @@ public static Row icebergRecordToBeamRow(Schema schema,
Record record) {
case FLOAT: // Iceberg and Beam both use float
case DOUBLE: // Iceberg and Beam both use double
case STRING: // Iceberg and Beam both use String
- case BOOLEAN: // Iceberg and Beam both use String
+ case BOOLEAN: // Iceberg and Beam both use boolean
case ARRAY:
case ITERABLE:
case MAP:
rowBuilder.addValue(icebergValue);
break;
case DATETIME:
- // Iceberg uses a long for millis; Beam uses joda time DateTime
- long millis = (long) icebergValue;
- rowBuilder.addValue(new DateTime(millis, DateTimeZone.UTC));
+ long micros;
Review Comment:
good call, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
