m-trieu commented on code in PR #32774:
URL: https://github.com/apache/beam/pull/32774#discussion_r1813350493
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcGetDataStream.java:
##########
@@ -188,20 +195,32 @@ private long uniqueId() {
@Override
public KeyedGetDataResponse requestKeyedData(String computation,
KeyedGetDataRequest request) {
- return issueRequest(
- QueuedRequest.forComputation(uniqueId(), computation, request),
- KeyedGetDataResponse::parseFrom);
+ try {
+ return issueRequest(
+ QueuedRequest.forComputation(uniqueId(), computation, request),
+ KeyedGetDataResponse::parseFrom);
+ } catch (
+
org.apache.beam.runners.dataflow.worker.windmill.client.WindmillStreamShutdownException
e) {
+ throw new WorkItemCancelledException(request.getShardingKey());
+ }
}
@Override
public GlobalData requestGlobalData(GlobalDataRequest request) {
- return issueRequest(QueuedRequest.global(uniqueId(), request),
GlobalData::parseFrom);
+ try {
+ return issueRequest(QueuedRequest.global(uniqueId(), request),
GlobalData::parseFrom);
+ } catch (
+
org.apache.beam.runners.dataflow.worker.windmill.client.WindmillStreamShutdownException
e) {
+ throw new WorkItemCancelledException(
Review Comment:
added TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
